Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fishPlugins.*: fix versions #354729

Merged
merged 1 commit into from
Nov 10, 2024
Merged

Conversation

Scrumplex
Copy link
Member

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Scrumplex
Copy link
Member Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 354729


x86_64-linux

✅ 12 packages built:
  • fishPlugins.bass
  • fishPlugins.bobthefish
  • fishPlugins.bobthefisher
  • fishPlugins.clownfish
  • fishPlugins.colored-man-pages
  • fishPlugins.foreign-env
  • fishPlugins.fzf
  • fishPlugins.fzf-fish
  • fishPlugins.grc
  • fishPlugins.humantime-fish
  • fishPlugins.hydro
  • fishPlugins.z

aarch64-linux

✅ 12 packages built:
  • fishPlugins.bass
  • fishPlugins.bobthefish
  • fishPlugins.bobthefisher
  • fishPlugins.clownfish
  • fishPlugins.colored-man-pages
  • fishPlugins.foreign-env
  • fishPlugins.fzf
  • fishPlugins.fzf-fish
  • fishPlugins.grc
  • fishPlugins.humantime-fish
  • fishPlugins.hydro
  • fishPlugins.z

aarch64-darwin

✅ 12 packages built:
  • fishPlugins.bass
  • fishPlugins.bobthefish
  • fishPlugins.bobthefisher
  • fishPlugins.clownfish
  • fishPlugins.colored-man-pages
  • fishPlugins.foreign-env
  • fishPlugins.fzf
  • fishPlugins.fzf-fish
  • fishPlugins.grc
  • fishPlugins.humantime-fish
  • fishPlugins.hydro
  • fishPlugins.z

@a-kenji
Copy link
Contributor

a-kenji commented Nov 9, 2024

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 354729


x86_64-linux

✅ 12 packages built:
  • fishPlugins.bass
  • fishPlugins.bobthefish
  • fishPlugins.bobthefisher
  • fishPlugins.clownfish
  • fishPlugins.colored-man-pages
  • fishPlugins.foreign-env
  • fishPlugins.fzf
  • fishPlugins.fzf-fish
  • fishPlugins.grc
  • fishPlugins.humantime-fish
  • fishPlugins.hydro
  • fishPlugins.z

@wegank wegank added 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package 12.approvals: 2 This PR was reviewed and approved by two reputable people labels Nov 10, 2024
@Guanran928
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 354729


x86_64-linux

✅ 12 packages built:
  • fishPlugins.bass
  • fishPlugins.bobthefish
  • fishPlugins.bobthefisher
  • fishPlugins.clownfish
  • fishPlugins.colored-man-pages
  • fishPlugins.foreign-env
  • fishPlugins.fzf
  • fishPlugins.fzf-fish
  • fishPlugins.grc
  • fishPlugins.humantime-fish
  • fishPlugins.hydro
  • fishPlugins.z

@Scrumplex Scrumplex merged commit 903f429 into NixOS:master Nov 10, 2024
28 checks passed
@Scrumplex Scrumplex deleted the push-qpvsxoqvmooq branch November 10, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 12.approvals: 2 This PR was reviewed and approved by two reputable people 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants