gitstatus: add grep to nativeBuildInputs for darwin
#359036
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In NixOS#358116 we found out that `drawin`'s `stdenv` lacks `grep` and breaks `libgit2` fork of `gitstatus`. The change adds `gnugrep` as a workaround until `stdenv` is fixed.
trofi
force-pushed
the
gitstatus-darwin-grep-hack
branch
from
7a6a16c to
130589b
Compare
|
Per #358116 (comment) I strongly suspect there is some weird Heisenbug causing |
|
Sounds good. Cached poisoned build sounds like thee real issue here. Looks like any derivation change would magically fix the build. |
|
I’m hoping it’s not a recurring problem and the next |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #358116 we found out that
drawin'sstdenvlacksgrepand breakslibgit2fork ofgitstatus. The change addsgnugrepas a workaround untilstdenvis fixed.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.