Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

steam: fix fhsenv version #359399

Closed
wants to merge 1 commit into from

Conversation

Stunkymonkey
Copy link
Contributor

part of #336576

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Pandapip1
Copy link
Contributor

It appears that steam-unwrapped doesn't have a version

@Stunkymonkey
Copy link
Contributor Author

It appears that steam-unwrapped doesn't have a version

steam-unwrapped can also be null... that is the current problem. I am leaving this as draft until fixed.

@Stunkymonkey
Copy link
Contributor Author

@Pandapip1 in this MR, I am in favor of closing it.

@ofborg ofborg bot requested review from Atemu, K900, mkg20001 and jagajaga November 28, 2024 13:09
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100 labels Nov 28, 2024
@Atemu
Copy link
Member

Atemu commented Nov 28, 2024

I think in the case of Steam it's actually intentional that it doesn't have a version.

While we do have a version of the Steam client that we fetch and provide (you should at least use that here), Steam updates itself outside of our control and could thereby update itself to be any version. I think it'd be confusing to claim that we are some specific version when in reality Steam will use whatever is the newest version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants