Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci/eval: don't allow IFD #360225

Merged
merged 1 commit into from
Nov 29, 2024
Merged

ci/eval: don't allow IFD #360225

merged 1 commit into from
Nov 29, 2024

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Nov 29, 2024

Things done

Tested in Mic92#40

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Mic92 Mic92 requested a review from infinisil November 29, 2024 20:52
@github-actions github-actions bot added the 6.topic: continuous integration Affects continuous integration (CI) in Nixpkgs, including Ofborg and GitHub Actions label Nov 29, 2024
@Mic92 Mic92 marked this pull request as draft November 29, 2024 20:58
infinisil
infinisil approved these changes Nov 29, 2024
View reviewed changes
Copy link
Member

@infinisil infinisil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Mic92 Mic92 marked this pull request as ready for review November 29, 2024 21:03
@infinisil infinisil merged commit 2aabd11 into NixOS:master Nov 29, 2024
16 of 17 checks passed
@Mic92 Mic92 deleted the ci-ifd branch November 29, 2024 21:22
@infinisil infinisil added the backport release-24.11 Backport PR automatically label Dec 2, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 2, 2024

Successfully created backport PR for release-24.11:

@github-actions github-actions bot mentioned this pull request Dec 2, 2024
Closed
1 task
@infinisil infinisil mentioned this pull request Dec 2, 2024
Merged
@infinisil
Copy link
Member

Manual backport: #361168

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil infinisil approved these changes

@LeSuisse LeSuisse Awaiting requested review from LeSuisse

@mweinelt mweinelt Awaiting requested review from mweinelt

@philiptaron philiptaron Awaiting requested review from philiptaron

@risicle risicle Awaiting requested review from risicle

Assignees
No one assigned
Labels
6.topic: continuous integration Affects continuous integration (CI) in Nixpkgs, including Ofborg and GitHub Actions backport release-24.11 Backport PR automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mic92 @infinisil