Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wechat-uos: fix fhsenv version #363162

Merged
merged 1 commit into from
Dec 10, 2024
Merged

wechat-uos: fix fhsenv version #363162

merged 1 commit into from
Dec 10, 2024

Conversation

Stunkymonkey
Copy link
Contributor

@Stunkymonkey Stunkymonkey commented Dec 8, 2024 •
edited
Loading

part of #336576

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Dec 8, 2024
@Stunkymonkey Stunkymonkey force-pushed the wechat-uos-fhsenv-version branch from b23b293 to 051c113 Compare December 8, 2024 19:05
@Stunkymonkey
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 363162

x86_64-linux

✅ 1 package built:
  • wechat-uos

@Stunkymonkey Stunkymonkey marked this pull request as ready for review December 8, 2024 19:15
@getchoo getchoo added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Dec 9, 2024
@ofborg ofborg bot requested review from xddxdd and pokon548 December 9, 2024 14:48
pokon548
pokon548 approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@pokon548 pokon548 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pokon548 pokon548 added 12.approvals: 2 This PR was reviewed and approved by two reputable people 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Dec 10, 2024
@getchoo getchoo merged commit 83da268 into NixOS:master Dec 10, 2024
48 of 49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pokon548 pokon548 pokon548 approved these changes

@getchoo getchoo getchoo approved these changes

@xddxdd xddxdd Awaiting requested review from xddxdd

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 2 This PR was reviewed and approved by two reputable people 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Stunkymonkey @getchoo @pokon548