linuxPackages: use pname and version instead of name #365953
Conversation
jopejoe1
force-pushed
the
linuxPackages-pname
branch
from
5d5061e to
a6c0b54
Compare
| @@ -55,7 +55,8 @@ let | |||
| ]; | |||
| in | |||
| stdenv.mkDerivation { | |||
| name = "broadcom-sta-${version}-${kernel.version}"; | |||
There was a problem hiding this comment.
With kernel modules in particular, it's really useful to have the particular kernel version be part of their name so you can see from the failing derivation itself what kernel version they failed against.
There was a problem hiding this comment.
Maybe we could make it a convention to add the kernel version to the derivation version.
i.e. version = "1.2.3-${kernel.version}";
There was a problem hiding this comment.
I like that convention, and it's going to be actually true -- the version is a tuple of the package's version and the kernel for which it's intended. Now that #234651 has landed, we could even encode that in a kernel-specific mkDerivation.
There was a problem hiding this comment.
The only major downside of this approach could be if someone wants to use finalAttrs.version for src.rev/src.tag.
If we had a kernel-specific mkDerivation, we could maybe store a moduleVersion and kernelVersion in finalAttrs though.
There was a problem hiding this comment.
If we had a kernel-specific
mkDerivation, we could maybe store amoduleVersionandkernelVersioninfinalAttrsthough.
Not only that -- we could use name to write out the name of the derivation however we wanted, while still requiring the users to use pname and version. The default mkDerivation behavior of name = "${pname}-${version}" is ours to change!
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.