Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fishy: init at 0.2.1 #366546

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fishy: init at 0.2.1 #366546

wants to merge 1 commit into from

Conversation

confusedalex
Copy link
Contributor

This PR inits fishy at 0.2.1.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • [] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

steeleduncan
steeleduncan suggested changes Dec 19, 2024
View reviewed changes
pkgs/by-name/fi/fishy/package.nix Outdated Show resolved Hide resolved
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1 10.rebuild-linux: 1 labels Dec 20, 2024
@confusedalex confusedalex self-assigned this Dec 20, 2024
@steeleduncan
Copy link
Contributor

I don't maintain any similar packages and I do not have the commit bit so it does not make sense for me to leave an approving review

To get this merged my suggestion would be that you find someone who has merged a rust PR recently and ping them to review it

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/5120

Defelo
Defelo reviewed Jan 21, 2025
View reviewed changes
pkgs/by-name/fi/fishy/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/fi/fishy/package.nix Show resolved Hide resolved
pkgs/by-name/fi/fishy/package.nix Show resolved Hide resolved
@confusedalex confusedalex requested a review from Defelo January 22, 2025 07:19
@Defelo
Copy link
Member

Defelo commented Jan 22, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 366546

x86_64-linux

✅ 1 package built:
  • fishy

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jan 23, 2025
@bbigras
Copy link
Contributor

bbigras commented Jan 25, 2025

Is fishy still relevant today? I'm not sure, but p2panda/fishy@848bbbc kinda sound like they are going into a new direction. Also, fishy didn't have an update in the last year except that commit.

@confusedalex
Copy link
Contributor Author

meli seems to use schemas. I am not really involved in p2panda so I don't know if they are deprecating it. I think it just doesn't see many commits because it's finished

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Defelo Defelo Defelo approved these changes

@steeleduncan steeleduncan Awaiting requested review from steeleduncan

Assignees

@confusedalex confusedalex

Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@confusedalex @steeleduncan @nixos-discourse @Defelo @bbigras @wegank