tiledb: fix libcxx builds #367289
Merged
tiledb: fix libcxx builds #367289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paparodeo
force-pushed
the
tidedb-libcxx-fix
branch
from
e6d543c to
b2eae10
Compare
github-actions
bot
added
10.rebuild-darwin: 11-100
10.rebuild-linux: 0
paparodeo
changed the title
libcxx (as of llvm-19) does not yet support `stop_token` and `jthread` without the -fexperimental-library flag. Tiledb adds its own implementations in the std namespace which conflict with libcxx. This test can be re-enabled once libcxx supports stop_token and jthread. https://hydra.nixos.org/build/281874632 https://cache.nixos.org/log/60fzb06ivb7cf4bx4f3varzib1wdyy5z-tiledb-2.18.2.drv
paparodeo
force-pushed
the
tidedb-libcxx-fix
branch
from
b2eae10 to
26f8cf4
Compare
paparodeo
changed the title
|
I don't think we need to wait with dropping this test for now. |
|
Though for me |
flaky tests? I had wcs.py::test_wcs_6 fail then passed when I built again on x64 darwin. gdal seems like it built on hydra |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libcxx (as of llvm-19) does not yet support
stop_tokenandjthreadwithout the -fexperimental-library flag. Tiledb adds its own implementations in the std namespace which conflict with libcxx. This test can be re-enabled once libcxx supports stop_token and jthread.https://hydra.nixos.org/build/281874632
https://cache.nixos.org/log/60fzb06ivb7cf4bx4f3varzib1wdyy5z-tiledb-2.18.2.drv
with this and the superlu #367110 fix gdal will again build on darwin.
TileDB-Inc/TileDB#5411
cc: @NixOS/geospatial due to gdal
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.