Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uchmviewer: init at 8.4 #372943

Merged
merged 1 commit into from
Feb 2, 2025
Merged

uchmviewer: init at 8.4 #372943

merged 1 commit into from
Feb 2, 2025

Conversation

azuwis
Copy link
Contributor

@azuwis azuwis commented Jan 11, 2025

Description: CHM (Winhelp) files viewer (fork of KchmViewer)

Homepage: https://github.com/eBookProjects/uChmViewer

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@azuwis
Copy link
Contributor Author

azuwis commented Jan 11, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 372943


x86_64-linux

✅ 1 package built:
  • uchmviewer

aarch64-darwin

✅ 1 package built:
  • uchmviewer

x86_64-darwin

✅ 1 package built:
  • uchmviewer

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/5096

Description: CHM (Winhelp) files viewer (fork of KchmViewer)

Homepage: https://github.com/eBookProjects/uChmViewer
@azuwis azuwis force-pushed the push-qqvzlntqzyrv branch from eafb909 to 5658935 Compare January 18, 2025 01:22
@azuwis
Copy link
Contributor Author

azuwis commented Jan 18, 2025

@GaetanLepage Thanks for the review, please check the new push.

I've used nix-update-script instead of gitUpdater, and I think versionCheckHook won't work here, the programs does not have a --version arg, see above comment.

@GaetanLepage
Copy link
Contributor

GaetanLepage commented Jan 18, 2025

I've used nix-update-script instead of gitUpdater

This is fine of course.
As this is a "simple" derivation (no cargoHash or similar), using gitUpdater is enough and preferred in this case.
Not necessarily a blocker though.

@azuwis
Copy link
Contributor Author

azuwis commented Feb 2, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 372943


x86_64-linux

✅ 1 package built:
  • uchmviewer

aarch64-darwin

✅ 1 package built:
  • uchmviewer

x86_64-darwin

✅ 1 package built:
  • uchmviewer

@azuwis
Copy link
Contributor Author

azuwis commented Feb 2, 2025

@GaetanLepage Anything left?

Copy link
Contributor

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, all good !

@GaetanLepage GaetanLepage merged commit 5df57fb into NixOS:master Feb 2, 2025
25 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants