-
-
Notifications
You must be signed in to change notification settings - Fork 15.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
uchmviewer: init at 8.4 #372943
uchmviewer: init at 8.4 #372943
Conversation
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/5096 |
Description: CHM (Winhelp) files viewer (fork of KchmViewer) Homepage: https://github.com/eBookProjects/uChmViewer
eafb909
to
5658935
Compare
@GaetanLepage Thanks for the review, please check the new push. I've used |
This is fine of course. |
|
@GaetanLepage Anything left? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, all good !
Description: CHM (Winhelp) files viewer (fork of KchmViewer)
Homepage: https://github.com/eBookProjects/uChmViewer
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.