buildPython*: Enable direct attribute overriding via overrideAttrs (the non-staging ones) #376372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShamrockLee
force-pushed
the
build-python-direct-overriding-simple
branch
from
3e8185a to
e46f723
Compare
12 tasks
13 tasks
ShamrockLee
force-pushed
the
build-python-direct-overriding-simple
branch
from
e46f723 to
8e74c50
Compare
Restructure the derivation to prepare for - fixed-point arguments support - overridePythonAttrs deprecation
ShamrockLee
force-pushed
the
build-python-direct-overriding-simple
branch
2 times, most recently
from
d96b56d to
f1bafe0
Compare
github-actions
bot
added
10.rebuild-darwin: 101-500
10.rebuild-linux: 501-1000
and removed
10.rebuild-darwin: 5001+
10.rebuild-linux: 5001+
labels
ShamrockLee
force-pushed
the
build-python-direct-overriding-simple
branch
from
f1bafe0 to
6dd94cd
Compare
github-actions
bot
added
10.rebuild-darwin: 11-100
10.rebuild-linux: 11-100
and removed
10.rebuild-darwin: 101-500
10.rebuild-linux: 501-1000
labels
ShamrockLee
force-pushed
the
build-python-direct-overriding-simple
branch
3 times, most recently
from
842c284 to
583c7e1
Compare
ShamrockLee
force-pushed
the
build-python-direct-overriding-simple
branch
from
583c7e1 to
d886b55
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the following attributes overridable using
overrideAttrs:srcremovePythonDepsrelaxPythonDepspassthru.build-systempassthru.dependenciespassthru.pyprojectDepends on (the diff will shorten once the dependency merges):
overridePythonAttrsdeprecation #375921Related PRs:
disabledand makepassthru.disabledoverridable usingoverrideAttrs:<pkg>.overridePythonAttrswork after<pkg>.overrideAttrs#267296nameand makepnameandversionoverridable usingoverrideAttrs:overrideAttrs:Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.