owncloud-client: 5.3.1 -> 5.3.2 #378553
Merged
owncloud-client: 5.3.1 -> 5.3.2 #378553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
10.rebuild-darwin: 0
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/5160 |
Comment on lines
7
to
6
| qt6, | ||
| qt6Packages, |
There was a problem hiding this comment.
Can we only use one of those?
There was a problem hiding this comment.
yes, I changed all to use qt6Packages.
Comment on lines
+9
to
+11
| # nativeBuildInputs | ||
| pkg-config, | ||
| cmake, | ||
| extra-cmake-modules, | ||
| qt6, | ||
| qt6Packages, | ||
| # buildInputs |
There was a problem hiding this comment.
We don't really need those comments.
There was a problem hiding this comment.
hmm, I'd keep them. I had another reviewer to explicitly ask me to keep these tidy and segmented. To whatever the convention, or lack of, I'd rather stick to it now. :)
There was a problem hiding this comment.
Sure whatever but there is no convention and I am way to lazy to maintain them so I usually nuke them
hellwolf
force-pushed
the
owncloud-client-v5.3.2
branch
from
8ade41a to
a9c69c0
Compare
SuperSandro2000
approved these changes
Feb 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.