runzip: fix build, drop unused libzip from buildInputs, enable tests #378802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Configure script produces a cryptic message: ``` configure:4540: error: ZLIB version too old, please install at least v1.1.2 ``` It's actually misleading and comes from the vendored libzip 0.7.1 configure check. It fails due to do `-Wimplicit-int`: ``` conftest.c:16:16: error: type defaults to 'int' in declaration of 'unzOpen' [-Wimplicit-int] 16 | extern ZEXPORT unzOpen (const char *path); ``` Vendored libzip is pretty heavily modified and unvendoring seems impossible. Furthermore, libzip from nixpkgs in buildInputs is actually unused and can be dropped - only zlib is necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configure script produces a cryptic message:
It's actually misleading and comes from the vendored libzip 0.7.1 configure check.
It fails due to do
-Wimplicit-int:Vendored libzip is pretty heavily modified and unvendoring seems impossible.
Furthermore, libzip from nixpkgs in buildInputs is actually unused and can be dropped - only zlib is necessary.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.