Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "mbrola: Fix compilation on Darwin" #378884

Merged
merged 1 commit into from
Feb 2, 2025

Conversation

mweinelt
Copy link
Member

@mweinelt mweinelt commented Feb 2, 2025

This reverts commit 479d878.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

This reverts commit 479d878.

This is not required any longer, after bumping mbrola to an unstable
version that contains these fixes.
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Feb 2, 2025
@mweinelt mweinelt merged commit 5e01e74 into NixOS:master Feb 2, 2025
41 of 50 checks passed
@mweinelt mweinelt deleted the mbrola-revert-patching branch February 2, 2025 17:25
@nix-owners nix-owners bot requested a review from davidak February 2, 2025 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant