maintainers: add name for tris203 #379894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Used name from their Github profile to unblock eval.
github-actions
bot
added
the
8.has: maintainer-list (update)
13 tasks
|
Successfully created backport PR for |
1 task
|
Git push to origin failed for release-24.11 with exitcode 1 |
github-actions
bot
added
10.rebuild-darwin: 0
1 task
|
@K900 any idea why this didn't get caught in checks? The backport had another eval failure when it was missing a new maintainer, but that one got caught. |
|
@infinisil is looking into it. |
|
This is the problem: nixpkgs/.github/workflows/eval-lib-tests.yml Lines 4 to 6 in 67fdf2c That workflow is supposed to catch this, but it only runs when lib is changed |
infinisil
added a commit
to tweag/nixpkgs
that referenced
this pull request
Feb 11, 2025
The lib tests also check maintainers, not doing so can cause problems: NixOS#379894
|
Fix here: #381283 |
JohnRTitor
pushed a commit
that referenced
this pull request
Feb 12, 2025
The lib tests also check maintainers, not doing so can cause problems: #379894
NyCodeGHG
pushed a commit
to NyCodeGHG/nixpkgs
that referenced
this pull request
Feb 14, 2025
The lib tests also check maintainers, not doing so can cause problems: NixOS#379894 (cherry picked from commit ec32f93)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used name from their Github profile to unblock eval.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.