ciscoPacketTracer8: fix build with noBrokenSymlinks

[gepbird]

Fixes #380374

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[wolfgangwalther]

Could you give a few words of explanation why this is the right change to make?

[gepbird]

Could you give a few words of explanation why this is the right change to make?

It fixes the build failure caused by #370750. See #380279 for a similar issue.

I tested the package and it works. Either ${fhs-env}/usr never existed or it was removed in some update or refactor.

[wolfgangwalther]

Sorry, I should have been more precise.

It fixes the build failure caused by #370750.

Yes, I understand that part.

I tested the package and it works.

I assumed that, yes.

Either ${fhs-env}/usr never existed or it was removed in some update or refactor.

This is what we should get more info on. I'm not happy with "it probably was that way". Let's find out, if we can. We should have at least a reasonable amount of understanding why this happens and why this is the right fix.

[wolfgangwalther]

Either ${fhs-env}/usr never existed or it was removed in some update or refactor.

So this seems to have been introduced in #356289, which claims:

This PR is mostly a revert of 2920b6f with additional refactors and the addition of wayland for newer versions of packet tracer.

It seems like the link was not created before that commit, so it seems to be newly-introduced in #356289.

Since then, there was only one commit for that file, which very likely didn't change anything.

So my best guess would be: It was not required from the beginning when it was introduced.

[gepbird]

Yes, I mistakenly added it, maybe because I tried to include the desktop file, then just used the declerative desktopItems attr, not entirely sure.