gap: ship Makefile.gappkg for future gap package use #380430
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We copy the testsuite to the outdir (#192548 (comment)) for installCheck purposes, but one test symlinks to etc/Makefile.gappkg, which we don't currently ship. I could delete the symlink, but the file is pretty small and I think upstream wants distros to ship it.
@fingolfin is it intentional that GAP's
make install
does not installetc/Makefile.gappkg
? I know many GAP packages ship with a copy of this file, but I thought the idea was to use an installed version if available.Fixes a build failure caused by #370750.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.