Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gap: ship Makefile.gappkg for future gap package use #380430

Merged
merged 1 commit into from
Feb 8, 2025

Conversation

collares
Copy link
Member

@collares collares commented Feb 8, 2025

We copy the testsuite to the outdir (#192548 (comment)) for installCheck purposes, but one test symlinks to etc/Makefile.gappkg, which we don't currently ship. I could delete the symlink, but the file is pretty small and I think upstream wants distros to ship it.

@fingolfin is it intentional that GAP's make install does not install etc/Makefile.gappkg? I know many GAP packages ship with a copy of this file, but I thought the idea was to use an installed version if available.

Fixes a build failure caused by #370750.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@collares collares force-pushed the gap-dangling-symlink branch from 5985f39 to 83205e2 Compare February 8, 2025 19:58
@collares collares changed the title gap: copy extra testsuite dependency to avoid dangling symlink gap: ship Makefile.gappkg for future gap package use Feb 8, 2025
@collares collares merged commit 81b20cb into NixOS:master Feb 8, 2025
55 of 58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant