Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

marwaita-icons: temporarily set dontCheckForBrokenSymlinks #380447

Merged
merged 1 commit into from
Feb 9, 2025

Conversation

romildo
Copy link
Contributor

@romildo romildo commented Feb 8, 2025

#370750 enforces no broken symlinks, I set dontCheckForBrokenSymlinks for now. And yes this is an upstream issue, and it has been reported:
darkomarko42/Marwaita-Icons#3

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1 10.rebuild-linux: 1-10 labels Feb 8, 2025
@Cryolitia Cryolitia mentioned this pull request Feb 8, 2025
13 tasks
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Feb 9, 2025
@wolfgangwalther wolfgangwalther merged commit fe21d2b into NixOS:master Feb 9, 2025
28 checks passed
Buer-Nahida pushed a commit to Buer-Nahida/nixpkgs that referenced this pull request Feb 9, 2025
Buer-Nahida pushed a commit to Buer-Nahida/nixpkgs that referenced this pull request Feb 9, 2025
@romildo romildo deleted the fix.marwaita-icons branch February 10, 2025 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants