tsm-client: fix symlink fixup #380705
Merged
tsm-client: fix symlink fixup #380705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`tsm-client` binary distribution apparently no longer contains any absolut `/usr/....` symlinks. On the other hand, there are some relative `..../opt/....` symlinks that haven't been fixed by the current build recipe. This fact got uncovered by the new `no-broken-symlinks` hook in aa1405b . The commit at hand updates and shortens the symlink fixup code such that it blanketly fixes all `...../opt/....` symlinks by removing one `../` directory level for each target.
github-actions
bot
added
10.rebuild-darwin: 0
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new setup hook
no-broken-symlinksuncovered some dangling symlinks intsm-client. The pull request at hand updates the symlink fixup code: It removes the fixup code for absolute/usr/....symlinks (such symlinks apparently vanished fromtsm-clientlong ago) and fixes the fixup code for relative..../opt/....symlinks so it correctly changes all such symlinks.Comparing the old package with the new one shows that dangling symlinks got fixed while no other symlinks are affected by this pull request. The new setup hook is also satisfied with the result.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)More:
nixpkgs-reviewtries to rebuild 2820 packages and was therefore skipped.Add a 👍 reaction to pull requests you find important.