venta: fix package by fixing broken symlink to marwaita #380706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `venta` theme package contained a broken symlink to "../../Marwaita/plank" in "$out/share/themes/Venta/plank/plank". From the perspective of an FHS-compatible directory structure, this symlink certainly wants to point to "/share/themes/Marwaita/plank". So redirecting this symlink to point to that position inside the `marwaita` theme package is the right thing to do. The commit at hand thereby also fixes the `venta` package, as dangling symlinks are no longer tolerated due to the new `no-broken-symlinks` setup hook introduced in commit aa1405b .
github-actions
bot
added
10.rebuild-darwin: 0
ConnorBaker
approved these changes
Feb 11, 2025
wegank
added
the
12.approvals: 1
wolfgangwalther
approved these changes
Feb 11, 2025
|
@Yarny0 if the maintainer hasn’t gotten back with a review in a few days let me know and I’ll merge it :) |
romildo
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new setup hook
no-broken-symlinksuncovered a dangling symlink in theventatheme package. Judging from the symlink's target, it wants to point to a certain file in themarwaitatheme package. This pull request replaces the symlink with a proper one that does point into themarwaitapackage.Notifying
ventamaintianer: @romildoThings done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)More
nixpkgs-reviewtries to rebuild 2999 packages and was therefore skipped.Add a 👍 reaction to pull requests you find important.