-
-
Notifications
You must be signed in to change notification settings - Fork 15.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
yazi-unwrapped: fix update script; use finalAttrs #385409
Conversation
8babe85
to
986124c
Compare
Looks good to me! Produced the following diff when run with diff --git i/pkgs/by-name/ya/yazi-unwrapped/package.nix w/pkgs/by-name/ya/yazi-unwrapped/package.nix
index 91812c39dd6d..14d97d43dc30 100644
--- i/pkgs/by-name/ya/yazi-unwrapped/package.nix
+++ w/pkgs/by-name/ya/yazi-unwrapped/package.nix
@@ -9,13 +9,13 @@
rust-jemalloc-sys,
}:
let
- version = "25.2.11";
+ version = "25.2.26";
code_src = fetchFromGitHub {
owner = "sxyazi";
repo = "yazi";
tag = "v${version}";
- hash = "sha256-yVpSoEmEA+/XF/jlJqKdkj86m8IZLAbrxDxz5ZnmP78=";
+ hash = "sha256-DqhqpQRCSBTGonL9+bP7pA3mO2CemlbhwzShVdrL1/0=";
};
man_src = fetchFromGitHub {
@@ -38,11 +38,11 @@ rustPlatform.buildRustPackage {
sourceRoot = code_src.name;
useFetchCargoVendor = true;
- cargoHash = "sha256-AfXi68PNrYj6V6CYIPZT0t2l5KYTYrIzJgrcEPLW8FM=";
+ cargoHash = "sha256-xg37aypFKY0ZG9GOkygTHlOAjqkTuhLNKo8Fz6MF2ZY=";
env.YAZI_GEN_COMPLETIONS = true;
env.VERGEN_GIT_SHA = "Nixpkgs";
- env.VERGEN_BUILD_DATE = "2025-02-11";
+ env.VERGEN_BUILD_DATE = "2025-02-26";
nativeBuildInputs = [ installShellFiles ];
buildInputs = [ rust-jemalloc-sys ] ++ lib.optionals stdenv.hostPlatform.isDarwin [ Foundation ];
|
986124c
to
e0a4353
Compare
This should be better for overriding sources
e0a4353
to
a773507
Compare
Since this is now much larger than an update script fix can we update the commit message and pull request title? |
I agree on the PR title, but the commits already describe what they do, so I don't think there is much to change there. |
Oops right I didn't notice you split the commits up already. My bad. Can again confirm that the update script correctly updates the package in all the right places and the updated package then builds as expected with that latest changes. |
The update script silently broke because of the changes to
srcs
and also becausenix-prefetch
is very outdated.Got the code to update the cargoHash from the scx update script.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.