xdg-desktop-portal-cosmic: 1.0.0-alpha.5.1 -> 1.0.0-alpha.6 #386198
Conversation
It wasn't used anymore, but it didn't get deleted
The service file was configured to use /bin/false which has two issues: 1. /bin 2. The service intentionally fails to start
github-actions
bot
added
10.rebuild-darwin: 0
There was a problem hiding this comment.
Not happy about the usage of the libcosmicAppHook without proper documentation for it first akin to how the Gnome Hooks are documented.
So I personally prefer that being done first, or at least in a follow up PR.
The rest looks good.
I can write documentation for it tomorrow in another PR |
|
Shouldn't this switch to using finalAttrs as well since support for rust got added here: #382550 ? |
|
Just because the support got added doesn't mean everything has to be done in one PR imho. But generally that would not be a bad idea, yes. |
Didn't know about that! That is cool, I can switch to it |
Maybe switch to |
|
|
This is odd, it wasn't failing before |
|
Maybe it is a me thing? Can you try building it? |
I did built it, it is failing now. ofborg builds is also failing. |
|
I got it. It will need a patch, I really don't know why it wasn't happening before. |
Apply upstream patch to fix compilation errors in example code that were causing test failures. The issues were related to API changes in the ashpd dependency
|
1 similar comment
|
Cargo.lockthat was forgotten to be removedxdg-desktop-portal-cosmicis now usinglibcosmicAppHook1.0.0-alpha.5.1to1.0.0-alpha.6Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.