Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos: programs.bash: Fix comment about completion #49746

Merged
merged 1 commit into from
Nov 4, 2018
Merged

nixos: programs.bash: Fix comment about completion #49746

merged 1 commit into from
Nov 4, 2018

Conversation

roberth
Copy link
Member

@roberth roberth commented Nov 4, 2018

Motivation for this change

XDG_DATA_DIRS already includes what is typically the share directory.
Adding an extra share breaks it.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@roberth
nixos: programs.bash: Fix comment about completion
c4f6745 
`XDG_DATA_DIRS` already includes what is typically the `share` directory.
Adding an extra `share` breaks it.
@roberth roberth requested a review from infinisil November 4, 2018 12:08
@GrahamcOfBorg GrahamcOfBorg added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Nov 4, 2018
@roberth
Copy link
Member Author

roberth commented Nov 4, 2018

Related to #26031

@roberth roberth merged commit 2adb521 into master Nov 4, 2018
@veprbl veprbl deleted the fix-nixos-bash-completion-comment branch December 14, 2018 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil infinisil approved these changes

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@roberth @infinisil @GrahamcOfBorg