Remove yarn2nix, see #20637 #58424
Merged
Remove yarn2nix, see #20637 #58424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrahamcOfBorg
added
8.has: clean-up
10.rebuild-darwin: 0
10 tasks
wizzup
reviewed
Apr 7, 2019
| yarn2nix = callPackage ../development/tools/yarn2nix { }; | ||
| inherit (yarn2nix) mkYarnPackage; | ||
|
|
||
| yarn2nix = throw "Use upstream https://github.com/moretea/yarn2nix"; |
There was a problem hiding this comment.
for yan2nix binary, why not using
yarn2nix = (callPackage (fetchFromGitHub {
owner = "moretea";
repo = "yarn2nix";
rev = "master";
sha256 = "1f83cr9qgk95g3571ps644rvgfzv2i4i7532q8pg405s4q5ada3h";
}) {}).yarn2nix;
There was a problem hiding this comment.
- This doesn't lock down the revision, so this will break as soon as something new is pushed to Yarn2nix's
master. - Nixpkgs doesn't allow importing from the output of derivations (such as fetches), since Hydra doesn't support that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#20637 cc @moretea
Uses outdated yarn2nix version, node 8.X, etc.