-
-
Notifications
You must be signed in to change notification settings - Fork 14.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
glibc: 2.27 -> 2.30 WIP #66528
glibc: 2.27 -> 2.30 WIP #66528
Conversation
You're a madman, and i support you on your journey ❤️ However, such a universal package may cause a lot more heart-ache than it's worth. (don't want you to get burnt out) |
cc @LnL7 |
Thanks for the fast reaction. I guess I have to ping @edolstra, as I don't know about anyone else. |
There seems to be some misunderstanding. Bootstrap files are substituted from cache.nixos.org (if present); see e.g. log from
Maybe I forgot some point. We certainly had at least one GitHub discussion about the (non-)utility of tarballs.nixos.org. |
as a workaround to fix build after updating stdenv bootstrap (in the followup commit). Interested parties can improve this later.
From Hydra's binaries for c5aabb0 (19.09). This time I re-tested full stdenv bootstrap on these three platforms. NixOS#66528 (comment)
@vcunat Thanks, I've copied the files. |
I suppose the diff of the glibc-upgrade branch is a bit cleaner without including these unnecessary changes.
Includes update of stdenv bootstap tools (for three main platforms) and many package fixes with new glibc.
Confirmed, except for the optional one (but that one doesn't matter). |
No, I copied it as well. Note that you have a typo in the URL ( |
Oh, right, typo; pushed as cf24265. First x86_64 binaries should start compiling today; the rest when staging-next get rotated. @lblasc: it's a bit unlucky that it was a difficult case and took us so much time – about half a year. Usually changes aren't so cumbersome, even mass rebuilds get merged basically every week. |
Repeated note: 32-bit ARMs are quite certainly broken by this PR. /cc @dezgeg (again) Regenerating bootstrap tools for them might suffice to fix them, but I don't have a good way of testing the builds natively. I suspect cross-building these platforms might keep working, except I now see that this PR broke evaluation of (all?) cross stuff 🤕 |
Can you please point me to a Hydra eval where I can see the errors? |
Fixes this build error: In file included from src/helper/options.c:38: /nix/store/dl4h1p847f2rsrsfvlmm6cxxx7q21kxj-glibc-2.30-dev/include/sys/sysctl.h:21:2: error: #warning "The <sys/sysctl.h> header is deprecated and will be removed." [-Werror=cpp] 21 | #warning "The <sys/sysctl.h> header is deprecated and will be removed." | ^~~~~~~ cc1: all warnings being treated as errors Fixes: 48a997c ("Merge #66528: glibc: 2.27 -> 2.30 (into staging)")
Uh-oh. These bootstrap tools no work on SLES 11-SP4
|
Just to properly understand your issue: you're using Nix on Sles11sp4 and our new bootstrap tools break the setup, right? However I'd like to point out that I'm pretty much against putting additional effort in fixing stuff for unmaintained versions of other distros (well unless you're paying for LTSS, but that's another story), but that's just my opinion :) |
@jcumming: did it even work before this PR? I've never looked into this for SLES/SLED. We haven't changed this part for quite a long time:
We have special patch to allow RHEL 6 -like kernels. That reminds me I last verified the real compatibility with that on glibc-2.26-131... so even though you don't get this nice refusal, some parts might not work on those kernels anymore. Well, today I suspect we might even drop RHEL 6 support 🤷♀️ I personally don't feel it's important anymore. |
To be clear, it isn't that much about bootstap... but about running anything built with our libc (i.e. with our stdenv). |
Actually, I think previous service packs with 2.6.32 kernel would not give you the error message, by co-incidence with RHEL 6 :-) |
Motivation for this change
Bump to latest glibc.
Started to fix core packages, managed to build and test
rustc
on x86_64.pkgs/stdenv/linux/bootstrap-files/*
? @grahamc @Mic92Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @edolstra