kernel/modules-closure.sh v2: fix the modules closure #69511
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xaverdh
changed the title
Prior to this commit the modules closure could reference nonsensical pieces of data in to form of module parameters. These were treated as seperate modules. "modprobe --show-depends" outputs a line of the form "insmod module_name module_args", we are only interested in the module name, so we extract it with sed. Also fixes a bug in the original implementation where the check for missing modules did not work as indended (the exit status of modprobe was ignored due to a pipe).
xaverdh
force-pushed
the
fix-modules-closure-v2
branch
from
e97a382 to
a25de74
Compare
ofborg
bot
added
10.rebuild-darwin: 0
infinisil
reviewed
Dec 11, 2019
10 tasks
|
I kind of forgot about this one, although the bug still triggers. Can / should we get more testing for this? |
|
closed in favour of #92081 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit the modules closure could reference nonsensical
pieces of data in to form of module parameters. These were treated
as seperate modules.
"modprobe --show-depends" outputs a line of the form
"insmod module_name module_args", we are only interested in the
module name, so we extract it with sed.
Also fixes a bug in the original implementation where the check for missing modules did not work as indended (the exit status of
modprobe was ignored due to a pipe).