Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

command-not-found: suggest nix-shell as well #74993

Closed
wants to merge 1 commit into from
Closed

command-not-found: suggest nix-shell as well #74993

wants to merge 1 commit into from

Conversation

raboof
Copy link
Member

@raboof raboof commented Dec 4, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

grahamc
grahamc reviewed Dec 4, 2019
View reviewed changes
nixos/modules/programs/command-not-found/command-not-found.pl
@@ -7,6 +7,7 @@
use Config;

my $program = $ARGV[0];
my $quoted_command = '"' . shell_quote(@ARGV) . '"';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this guaranteed to be correct?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

likely not - but for corner cases what is 'correct' might be different depending on what shell the user is using, and taking that into account seems excessive.

FRidh
FRidh requested changes Dec 4, 2019
View reviewed changes
nixos/modules/programs/command-not-found/command-not-found.pl
@@ -38,6 +39,9 @@
print STDERR <<EOF;
The program ‘$program’ is currently not installed. You can install it by typing:
nix-env -iA nixos.$package

Or run it once with:
nix-shell -p $package --run $quoted_command
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that should be nix run then, not nix-shell

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix run is "experimental" and may even disappear behind a feature flag in the next release.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, I've seen that change. That's really backwards. nix-shell is causing lots of trouble for just running applications because of the hooks, now we have a solution, and then it would "disappear" again 😕

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I agree. But we shouldn't recommend it until that problem is solved.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is putting nix run behind a feature flag discussed? I find it very useful.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NixOS/nix@aabf5c8

nixos/modules/programs/command-not-found/command-not-found.pl
@@ -46,6 +50,8 @@
several packages. You can install it by typing one of the following:
EOF
print STDERR " nix-env -iA nixos.$_->{package}\n" foreach @$res;
print STDERR "\nOr run it once with:\n";
print STDERR " nix-shell -p $_->{package} --run $quoted_command\n" foreach @$res;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Dec 4, 2019
@FRidh
Copy link
Member

FRidh commented Dec 4, 2019

see also #74789

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Dec 4, 2019
@prusnak
Copy link
Member

prusnak commented Dec 4, 2019

Conflicts with #74789 (rewrite of command-not-found to C++)

@raboof
Copy link
Member Author

raboof commented Dec 5, 2019

Conflicts with #74789 (rewrite of command-not-found to C++)

Yes, though only somewhat: merging this before #74789 might be fine (it would be an easy-to-resolve conflict there, and make the feature disappear again when #74789 is merged, but I'd say that's fine). Indeed when #74789 is merged first we can close this one (and I could look into building the feature in C++ instead).

(#74789 looks fine to me but from the comments it seemed somewhat controversial, so I wasn't sure whether to expect it to be merged any time soon (or at all) )

@raboof raboof closed this Jan 8, 2020
@raboof
Copy link
Member Author

raboof commented Apr 19, 2020

Reopening this since #74789 doesn't seem to moving forward for now.

(when #74789 gets merged it's not big deal if this small improvement is lost, and I'll try to PR it there as well :))

@raboof raboof reopened this Apr 19, 2020
@ofborg ofborg bot added 10.rebuild-linux: 1-10 and removed 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Apr 19, 2020
@raboof
Copy link
Member Author

raboof commented Jul 7, 2020

It looks like all improvements of command-not-found are stalled because there is a plan to replace it with nix-index (#39789).

I guess I should take that for a spin (as documented at https://github.com/bennofs/nix-index#usage-as-a-command-not-found-replacement) and if it seems nice port this PR to that tool.

@raboof raboof closed this Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grahamc grahamc grahamc left review comments

@Moredread Moredread Moredread left review comments

@FRidh FRidh FRidh requested changes

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@raboof @FRidh @prusnak @grahamc @Moredread