glibc: 2.30 -> 2.31

[Ma27]

Motivation for this change

Changelog: https://sourceware.org/ml/libc-announce/2020/msg00001.html
Hydra jobset: https://hydra.nixos.org/jobset/nixpkgs/glibc-231

Things done

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Determined the impact on package closure size (by running nix path-info -S before and after)
• Ensured that relevant documentation is up to date
• Fits CONTRIBUTING.md.

[FRidh]

Could the Hydra job be stopped? Now around branch-off we need the Hydra capacity.
https://hydra.nixos.org/jobset/nixpkgs/glibc-231#tabs-evaluations

[vcunat]

OK, done. I don't expect there will immediately be human time for stabilizing yet another glibc bump anyway. (We haven't really fixed the previous one yet.)

EDIT: I had reduced the scheduling shares on that jobset some days ago, so the impact hopefully wasn't too large.

[Ma27]

Agreed, that's why I added this to the 20.09 milestone :) Was mainly interested how much that one would break.

[FRidh]

Hydra is not doing much at the moment, and we don't have anything significant in staging either, so I suggest rebasing this and evaluating a single jobset.

[Ma27]

Thanks for the heads-up, rebased onto latest staging, Hydra evaluation is currently running :)

[Ma27]

Btw feel free to abort the jobset if this consumes too much resources (I don't have the permission to do that).

[vcunat]

In config it has very few scheduling shares, so Hydra should automatically give priority to other jobs.

[Ma27]

@vcunat the branch now points to staging. For testing purposes I built hello on aarch64-linux :)

I'll mark this as "Ready for review" now, but from my PoV this seems mergable.

[vcunat]

I had a glance at the stable 2.31 branch (NEWS). First of all, the ./2.30-cve-2020-1752.patch is still needed (you haven't deleted the file... maybe a rebasing conflict), and CVE-2020-10029 sounds important to add as well.

Perhaps we could again take the whole stable branch; the main complication there is around bootstrapping, so I used to do that in an ugly way: generate the large diff (all commits together since 2.31) and put that gzipped into nixpkgs.

[Ma27]

@vcunat applied the two CVE patches for now.

[vcunat]

Seems suitable for staging branch.

[Ma27]

@vcunat so, as soon as ofborg is ready (and we have a few more reviews?), this is mergable?

[Ma27]

@vcunat btw I assume that the Hydra jobset (https://hydra.nixos.org/jobset/nixpkgs/glibc-231) can be disabled now, right?

[vcunat]

OK. Auto-evals were disabled long ago; now I disabled it whole.

[nixos-discourse]

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/bad-locale-support-perl-warning-setting-locale-failed/8261/1