-
-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LLVM: mark as big-parallel #86063
LLVM: mark as big-parallel #86063
Conversation
Question: should we only apply big-parallel on aarch64? This might reduce the rebuilt amount? |
With the number of rebuilds, this should go to |
LLVM builds frequently time out on hydra at least on AArch64. Marking big-parallel gives them more resources to finish quicker.
LLVM builds frequently time out on hydra at least on AArch64. Marking big-parallel gives them more resources to finish quicker.
LLVM builds frequently time out on hydra at least on AArch64. Marking big-parallel gives them more resources to finish quicker.
LLVM builds frequently time out on hydra at least on AArch64. Marking big-parallel gives them more resources to finish quicker.
73701c3
to
8d8c050
Compare
Rebased to staging, wasn't sure at first whether a change in requiredSystemFeatures would cause rebuilds. |
Will this have any effect? As far as I know big-parallel is one of the "legacy" features that every Nix installation has on by default. https://github.com/NixOS/nixos-org-configurations/search?q=big-parallel&unscoped_q=big-parallel also doesn't yield anything interesting. |
I think it's largely an infrastructure optimization, as the wiki section on distributed builds mentions it. https://nixos.wiki/wiki/Distributed_build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️ except that llvm 10 is missing. I think it's worth picking to staging-20.03
as well, on the next big rebuild.
LLVM builds frequently time out on hydra at least on AArch64. Marking big-parallel gives them more resources to finish quicker.
llvm_10 added |
unfortunately, these are all broken currently
EDIT: fixed by: #86260 |
Motivation for this change
LLVM frequently times out (see https://hydra.nixos.org/job/nixos/release-20.03-aarch64/nixpkgs.llvm_9.aarch64-linux as an example), hopefully marking as big-parallel should give it enough resources to finish quicker. LLVM 5 was already marked as big-parallel, so I went and marked the newer versions big-parallel as well.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)