Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exoscale-cli: 1.12.0 -> 1.14.0 #92705

Merged
merged 2 commits into from
Jul 9, 2020
Merged

exoscale-cli: 1.12.0 -> 1.14.0 #92705

merged 2 commits into from
Jul 9, 2020

Conversation

dramaturg
Copy link
Contributor

Motivation for this change

Update to latest release of the exoscale cli

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dramaturg
Copy link
Contributor Author

/marvin opt-in
/status needs_reviewer

@marvin-mk2 marvin-mk2 bot added marvin This PR was reviewed by Marvin, a discontinued bot: https://github.com/timokau/marvin-mk2 needs_reviewer (old Marvin label, do not use) labels Jul 8, 2020
@marvin-mk2
Copy link

marvin-mk2 bot commented Jul 8, 2020

@turion please review.

@marvin-mk2 marvin-mk2 bot added awaiting_reviewer (old Marvin label, do not use) and removed needs_reviewer (old Marvin label, do not use) labels Jul 8, 2020
@turion
Copy link
Contributor

turion commented Jul 8, 2020

Binary executes.

@timokau timokau mentioned this pull request Jul 8, 2020
Merged
@turion
Copy link
Contributor

turion commented Jul 8, 2020

/status needs_work

@turion
Copy link
Contributor

turion commented Jul 8, 2020

@timokau What am I doing wrong here?

@timokau
Copy link
Member

timokau commented Jul 8, 2020

The needs_work status doesn't exist anymore since timokau/marvin-mk2#29. The closest equivalent is awaiting_changes. Most of the time you should just let Marvin do its thing though, you don't have to set the state explicitly. It sets to awaiting_changes when you leave a change-requesting review. Its has recently become a bit more conservative with switching to that state (timokau/marvin-mk2#58), since it doesn't hurt much to have a PR in awaiting_reviewer by mistake but it may hurt a lot to have it in awaiting_changes by mistake.

Marvin should of course have linked the usage document on opt-in, it failed to do so (timokau/marvin-mk2#62).

@turion
Copy link
Contributor

turion commented Jul 8, 2020

@timokau Thanks for your detailed explanations.

/status awaiting_changes

@marvin-mk2 marvin-mk2 bot added awaiting_changes (old Marvin label, do not use) and removed awaiting_reviewer (old Marvin label, do not use) labels Jul 8, 2020
@dramaturg
Copy link
Contributor Author

@turion Err... what needs to be changed here?

@marvin-mk2 marvin-mk2 bot added awaiting_reviewer (old Marvin label, do not use) and removed awaiting_changes (old Marvin label, do not use) labels Jul 8, 2020
@turion
Copy link
Contributor

turion commented Jul 8, 2020

@turion Err... what needs to be changed here?

As I said in #92705 (comment) it would be nice to split into two commits where one contains your refactoring and the other does the version bump :)

@Mic92
Copy link
Member

Mic92 commented Jul 8, 2020

Result of nixpkgs-review pr 92705 1

1 package built:
- exoscale-cli

@turion
Copy link
Contributor

turion commented Jul 9, 2020

Awesome!

/status needs_merger

@marvin-mk2 marvin-mk2 bot added needs_merger (old Marvin label, do not use) and removed awaiting_reviewer (old Marvin label, do not use) labels Jul 9, 2020
@marvin-mk2 marvin-mk2 bot requested a review from timokau July 9, 2020 08:44
@marvin-mk2 marvin-mk2 bot added awaiting_merger (old Marvin label, do not use) and removed needs_merger (old Marvin label, do not use) labels Jul 9, 2020
@timokau timokau merged commit 3e38887 into NixOS:master Jul 9, 2020
@dramaturg dramaturg deleted the exoscale-cli branch August 21, 2020 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turion turion turion left review comments

@timokau timokau Awaiting requested review from timokau

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes awaiting_merger (old Marvin label, do not use) marvin This PR was reviewed by Marvin, a discontinued bot: https://github.com/timokau/marvin-mk2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dramaturg @turion @timokau @Mic92