Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/sssd: fix the module #96179

Merged
merged 1 commit into from
Aug 25, 2020
Merged

nixos/sssd: fix the module #96179

merged 1 commit into from
Aug 25, 2020

Conversation

bbigras
Copy link
Contributor

@bbigras bbigras commented Aug 24, 2020

Motivation for this change

'system.nssModules' was not set correctly

fix #91242

Things done

I added a simple test just to make sure the service builds and starts when using services.sssd.enable. I'm interested in making that test better eventually.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @e-user

@bbigras
nixos/sssd: fix the module
5d36e00 
'system.nssModules' was not set correctly

fix NixOS#91242
@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Aug 24, 2020
@bbigras
Copy link
Contributor Author

bbigras commented Aug 25, 2020

/marvin opt-in
/status needs_reviewer

@marvin-mk2 marvin-mk2 bot added the marvin This PR was reviewed by Marvin, a discontinued bot: https://github.com/timokau/marvin-mk2 label Aug 25, 2020
@marvin-mk2
Copy link

marvin-mk2 bot commented Aug 25, 2020

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@marvin-mk2 marvin-mk2 bot added the needs_reviewer (old Marvin label, do not use) label Aug 25, 2020
@bbigras
Copy link
Contributor Author

bbigras commented Aug 25, 2020

@aanderse maybe you can help with this simple PR.

outergod
outergod approved these changes Aug 25, 2020
View reviewed changes
Copy link
Contributor

@outergod outergod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marvin-mk2 marvin-mk2 bot added awaiting_reviewer (old Marvin label, do not use) and removed needs_reviewer (old Marvin label, do not use) labels Aug 25, 2020
@bbigras
Copy link
Contributor Author

bbigras commented Aug 25, 2020

/status needs_merger

@marvin-mk2
Copy link

marvin-mk2 bot commented Aug 25, 2020

The PR author cannot set the status to needs_merger. Please wait for an external review.

If you are not the PR author and you are reading this, please review the usage of this bot. You may be able to help. Please make an honest attempt to resolve all outstanding issues before setting to needs_merger.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/209

@AndersonTorres AndersonTorres merged commit fffabfa into NixOS:master Aug 25, 2020
@bbigras bbigras deleted the sssd branch August 25, 2020 20:09
@bbigras
Copy link
Contributor Author

bbigras commented Aug 25, 2020

Thanks!!

@aanderse
Copy link
Member

@bbigras sorry I was late to the party on this one. Next time.

@bbigras
Copy link
Contributor Author

bbigras commented Aug 26, 2020

No worries 😊 thanks for the reply

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@outergod outergod outergod approved these changes

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux awaiting_reviewer (old Marvin label, do not use) marvin This PR was reviewed by Marvin, a discontinued bot: https://github.com/timokau/marvin-mk2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change to sssd.nix causes nixos build scripts to fail with error
5 participants
@bbigras @nixos-discourse @aanderse @outergod @AndersonTorres