Core Refactorization + Reconcilers.fit

[kdgutier]

Refactorization of core.HierarchicalForecast.reconcile:

• Simplified nested ifs and redundant conditions in core.reconcile.
• Separated input's declaration from sampler's instantiation in core.reconcile.

To allow for sample method, added P, W memory and sampler instantiation to all reconcilers in methods.py:

• Renamed reconcile -> fit_predict.

• Added fit method that obtains self.P, self.W and instantiates self.sampler.

• Momentarily: _get_sampler function.

• Momentarily: Change notebooks tests to instantiate samplers within reconcilers.

• Confirmed that all examples run and replicate previous work.

PENDING:

• Declaration of predict, and sample reconciler methods.
• Redefine reconcilers initialization to receive samplers mimicking NeuralForecasts loss modules.
• Maybe add a fit method to samplers to allow for Reconcilers + sampler initialization.

[review-notebook-app]

Check out this pull request on 

See visual diffs & provide feedback on Jupyter Notebooks.

---

Powered by ReviewNB