Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT] Reconciler's sample method #133

Merged
merged 8 commits into from
Dec 15, 2022
Merged

[FEAT] Reconciler's sample method #133

merged 8 commits into from
Dec 15, 2022

Conversation

kdgutier
Copy link
Collaborator

  • Added get_sample to multivariate normal reconciler.
  • Added num_samples parameter to get_sample methods.
  • Inherit sample method to all reconcilers through HReconciler
  • Added shape unit tests in probabilistic_methods.ipynb and methods.ipynb

@kdgutier kdgutier requested a review from cchallu December 15, 2022 02:19
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@kdgutier kdgutier changed the title Reconciler's sample [FEAT] Reconciler's sample method Dec 15, 2022
@kdgutier kdgutier linked an issue Dec 15, 2022 that may be closed by this pull request
Reconciler class inheritance. #132
Closed
@cchallu cchallu merged commit 931d0bf into main Dec 15, 2022
@cchallu cchallu deleted the reconcilers_sample branch December 15, 2022 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cchallu cchallu cchallu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reconciler class inheritance.
2 participants
@kdgutier @cchallu