[FEAT] NeuralForecast Compatibility and Example Notebook #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
kdgutier
requested changes
Apr 24, 2023
There was a problem hiding this comment.
Pretty cool work.
Is it possible to include the MLFrameworksExample.ipynb notebook in the sidebar.yml for it to appear in the documentation.
This change in the sidebar.yml should suffice.
- section: ML Forecast Reconciliation
contents:
- examples/MLFrameworksExample.ipynb
kdgutier
approved these changes
Apr 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Neuralforecast library outputs dataframes with a "[Model]-median" column, so I added some logic to handle the "-median" column.
I also added an additional example notebook which demonstrates how to use HF with NF and MLF.