Add openCurlie and closeCurlie icons #742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macoca
force-pushed
the
growth/add-curlie-icons
branch
3 times, most recently
from
184b89d to
7ea88f5
Compare
macoca
force-pushed
the
growth/add-curlie-icons
branch
from
7ea88f5 to
8364189
Compare
tesk9
approved these changes
Oct 12, 2021
There was a problem hiding this comment.
Looks good! Although I think openQuotationMark or something like that might be slightly more clear than openCurlie, since there are lots of curlie things. But not blocking by any means!
I pushed a commit adding to the styleguide example app:
|
You're totally right about the names! I'll change them now. Thanks! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will add
openCurlieandcloseCurlieicons.