New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(api): saveHTMLOnDisk option #398

Merged

PierreDemailly merged 1 commit into master from save-html-on-disk-option

Jul 28, 2024

Member

PierreDemailly commented Jul 28, 2024

When savePDFOnDisk was truthy and no reportOutputLocation was given, we generated the PDF in the temp folder which is not practical.

I've added a new option saveHTMLOnDisk and changed this behavior.

if a least one report file must be saved (savePDFOnDisk or saveHTMLOnDisk) then we don't fallback reportOutputLocation to the temp directory but CWD instead.
we remove the created HTML report when the new option saveHTMLOnDisk is falsy (by default).


          feat(api): saveHTMLOnDisk option

063e84f

PierreDemailly requested a review from fraxken

July 28, 2024 09:46

fraxken approved these changes

View reviewed changes

PierreDemailly merged commit 1f2637e into master

4 checks passed

PierreDemailly deleted the save-html-on-disk-option branch

July 28, 2024 18:10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet