Add sub actions #11
Add sub actions #11
Conversation
There was a problem hiding this comment.
The overall looks great and I understand the general direction, but I have a couple of questions about the file structure. Would you mind explaining the reasoning behind having three Dockerfiles and two entrypoint.sh files? I'm wondering if there might be a way to consolidate them for maintainability.
I know there are copies, this is just quick and fast implementation to solve this. Feel free to fix it but there is no practical benefit of a clean up from a maintenance point of view. One just edit all files with vim and run: |
|
@simonsso @trsmarc we can have one Dockerfile and entrypoint set to Doing so will allow us to reuse the current prebuild step which will greatly improve CI time, and also reduce the number of docker images to pull when running CI - which also avoids CI taking too long. |
| if [ -f "$runtime" ];then | ||
| try-runtime --runtime $runtime on-runtime-upgrade --checks=$checks $* snap --path $snap | ||
| fi |
There was a problem hiding this comment.
I am not sure this will do what you want since if runtime == SKIP this will still evaluate to true?
There was a problem hiding this comment.
check man [
then scroll down to;
-f FILE
FILE exists and is a regular file
Any non existing argument will skip
| @@ -11,7 +11,7 @@ inputs: | |||
| description: 'Path to a previously taken snapshot, if does not exists we will create it' | |||
| default: '/tmp/default.snap' | |||
| runtime: | |||
| description: 'Path to a try-runtime enabled runtime to test migrations for' | |||
| description: 'Path to a try-runtime enabled runtime to test migrations for, Set to SKIP to skip test and only download snapshot' | |||
| required: true | |||
There was a problem hiding this comment.
You can change this to false if you want to make this option optional
There was a problem hiding this comment.
There is a complication in how it is transferred to the Dockers' entrypoint with $1 $2 $3 $4
Maybe, I would just get his to work before we spend time to optimize it. I intend to put the actions in different CI jobs and foresee other bottle necks to have larger impact first. The docker container is recreated in a few seconds in a job which will run for 10-20 minutes once every day or so. Not worth optimizing. |
I created a ticket to look into this on a rainy day |
This reverts commit 2e6a4e1.
No description provided.