Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nodle parachain bring-up #430

Conversation

rajesh-nodle
Copy link
Contributor

@rajesh-nodle rajesh-nodle commented Nov 19, 2021

Plz ignore this | My local branch got corrupted

Active one is | #433

nodle parachain bring-up

Signed-off-by: R.RajeshKumar <[email protected]>
Signed-off-by: R.RajeshKumar <[email protected]>
Signed-off-by: R.RajeshKumar <[email protected]>
Signed-off-by: R.RajeshKumar <[email protected]>
Signed-off-by: R.RajeshKumar <[email protected]>
Signed-off-by: R.RajeshKumar <[email protected]>
Signed-off-by: R.RajeshKumar <[email protected]>
@rajesh-nodle rajesh-nodle requested review from ETeissonniere and a team November 19, 2021 11:18
Signed-off-by: R.RajeshKumar <[email protected]>
vec![get_account_id_from_seed::<sr25519::Public>("Ferdie")],
None,
None,
1000.into(),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't that come from a CLI flag?

node/src/command.rs Show resolved Hide resolved
node/src/command.rs Outdated Show resolved Hide resolved
node/src/command.rs Outdated Show resolved Hide resolved
node/src/command.rs Outdated Show resolved Hide resolved
primitives/src/network.rs Show resolved Hide resolved
primitives/src/tokens.rs Show resolved Hide resolved
Comment on lines +81 to +87
// Governance
TechnicalCommittee: pallet_collective::<Instance2>::{Pallet, Call, Storage, Origin<T>, Event<T>, Config<T>} = 5,
TechnicalMembership: pallet_membership::<Instance1>::{Pallet, Call, Storage, Event<T>, Config<T>} = 6,
FinancialCommittee: pallet_collective::<Instance3>::{Pallet, Call, Storage, Origin<T>, Event<T>, Config<T>} = 7,
FinancialMembership: pallet_membership::<Instance3>::{Pallet, Call, Storage, Event<T>, Config<T>} = 8,
RootCommittee: pallet_collective::<Instance4>::{Pallet, Call, Storage, Origin<T>, Event<T>, Config<T>} = 9,
RootMembership: pallet_membership::<Instance4>::{Pallet, Call, Storage, Event<T>, Config<T>} = 10,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do not need those.

RootCommittee: pallet_collective::<Instance4>::{Pallet, Call, Storage, Origin<T>, Event<T>, Config<T>} = 9,
RootMembership: pallet_membership::<Instance4>::{Pallet, Call, Storage, Event<T>, Config<T>} = 10,
Scheduler: pallet_scheduler::{Pallet, Call, Storage, Event<T>} = 11,
Amendments: pallet_amendments::{Pallet, Call, Storage, Event<T>} = 12,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessary

Comment on lines +116 to +117
PkiTcr: pallet_tcr::<Instance1>::{Pallet, Call, Storage, Event<T>} = 33,
PkiRootOfTrust: pallet_root_of_trust::{Pallet, Call, Storage, Event<T>} = 34,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to be removed

runtimes/eden/src/version.rs Outdated Show resolved Hide resolved
runtimes/eden/src/version.rs Outdated Show resolved Hide resolved
runtimes/eden/src/version.rs Outdated Show resolved Hide resolved
rajesh-nodle and others added 7 commits November 25, 2021 12:58
Co-authored-by: Eliott Teissonniere <[email protected]>
Co-authored-by: Eliott Teissonniere <[email protected]>
Co-authored-by: Eliott Teissonniere <[email protected]>
Co-authored-by: Eliott Teissonniere <[email protected]>
Co-authored-by: Eliott Teissonniere <[email protected]>
Co-authored-by: Eliott Teissonniere <[email protected]>
Co-authored-by: Eliott Teissonniere <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants