Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve CI and lint #604

Merged
merged 14 commits into from
May 19, 2022
Merged

improve CI and lint #604

merged 14 commits into from
May 19, 2022

Conversation

ETeissonniere
Copy link
Member

@ETeissonniere ETeissonniere commented May 18, 2022

refactor our CI config to make better use of linters:

  • run with latest releases of our testing dependencies
  • update rustfmt config
  • add support for clippy
  • refactor CI action accordingly
  • apply new listing recommendations (⚠️ lots of changes, mainly license header, clippy and fmt recommendations)
  • update devcontainer to support clippy

likely to conflict with #603

@codecov
Copy link

codecov bot commented May 18, 2022

Codecov Report

Merging #604 (eaf19ac) into master (1cb8bac) will increase coverage by 0.45%.
The diff coverage is 65.69%.

@@            Coverage Diff             @@
##           master     #604      +/-   ##
==========================================
+ Coverage   81.82%   82.28%   +0.45%     
==========================================
  Files          66       66              
  Lines        8508     7992     -516     
==========================================
- Hits         6962     6576     -386     
+ Misses       1546     1416     -130     
Impacted Files Coverage Δ
nodes/main/src/command.rs 0.00% <0.00%> (ø)
nodes/main/src/executor.rs 0.00% <0.00%> (ø)
nodes/main/src/main.rs 0.00% <0.00%> (ø)
nodes/main/src/rpc.rs 0.00% <0.00%> (ø)
nodes/main/src/service.rs 0.00% <0.00%> (ø)
nodes/parachain/src/chain_spec.rs 0.00% <0.00%> (ø)
nodes/parachain/src/cli.rs 0.00% <0.00%> (ø)
nodes/parachain/src/rpc.rs 0.00% <0.00%> (ø)
nodes/parachain/src/service.rs 0.00% <0.00%> (ø)
nodes/staking/src/chain_spec.rs 0.00% <0.00%> (ø)
... and 78 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1cb8bac...eaf19ac. Read the comment docs.

@ETeissonniere ETeissonniere marked this pull request as ready for review May 18, 2022 16:22
@ETeissonniere ETeissonniere merged commit 16547f6 into master May 19, 2022
@ETeissonniere ETeissonniere deleted the eliott/clippy branch May 19, 2022 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant