Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fredrik/polkadot_v0.9.27 #660

Merged
merged 3 commits into from
Aug 23, 2022
Merged

Fredrik/polkadot_v0.9.27 #660

merged 3 commits into from
Aug 23, 2022

Conversation

simonsso
Copy link
Contributor

@simonsso simonsso commented Aug 17, 2022

Upgrade to polkadot v0.9.27

Build ok
Benchmarks run
Try runitme green
Local testnet starting.

Ready for testnet.

@codecov
Copy link

codecov bot commented Aug 17, 2022

Codecov Report

Merging #660 (3a510c9) into master (643b448) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #660      +/-   ##
==========================================
+ Coverage   89.64%   89.67%   +0.02%     
==========================================
  Files          33       33              
  Lines        6169     6167       -2     
==========================================
  Hits         5530     5530              
+ Misses        639      637       -2     
Impacted Files Coverage Δ
node/src/service.rs 0.00% <ø> (ø)
pallets/allocations/src/tests.rs 93.84% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@simonsso simonsso requested a review from a team August 18, 2022 08:12
@@ -267,4 +267,4 @@ fn no_issuance() {
Errors::BatchEmpty
);
})
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this was added by cargo fmt, and I agree, I think we should have newlines at EOF

Copy link
Contributor

@aliXsed aliXsed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ETeissonniere
Copy link
Member

Amazing! Let's make sure Zondax and Mobile run their tests once it lands on the testnet as usual

@simonsso simonsso merged commit 28aa6c8 into master Aug 23, 2022
@simonsso simonsso deleted the fredrik/polkadot_v0.9.27 branch August 23, 2022 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants