correct storage of new pallets and prepare release #723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonsso
reviewed
Mar 24, 2023
runtimes/eden/src/migrations.rs
Outdated
| } | ||
| log::info!(target: TRY_RUNTIME, "Contracts storage version was good"); | ||
|
|
||
| if let Some(xcm_version) = |
There was a problem hiding this comment.
Use this a a final statement and embed the Ok(()) in the correct place and end the others without return, then the compiler will check all arms are covered for us.
There was a problem hiding this comment.
I think because I didn't have else statements in my structure, I had to return explicitly.
Codecov Report
@@ Coverage Diff @@
## master #723 +/- ##
==========================================
- Coverage 42.90% 42.43% -0.48%
==========================================
Files 38 38
Lines 4391 4440 +49
==========================================
Hits 1884 1884
- Misses 2507 2556 +49
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
ETeissonniere
approved these changes
Mar 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The on chain version of the pallets should match the pallets versions for newly added pallets. Also the safe xcm version for PolkadotXcm should be set manually.