Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sponsorship vector implementation #836

Merged
merged 11 commits into from
Mar 22, 2024
Merged

Conversation

simonsso
Copy link
Contributor

@simonsso simonsso commented Mar 18, 2024

  • tests for positive case where all pass
  • test where some jobs pass but on fails and all is rolled back
  • benchmark

@simonsso simonsso marked this pull request as draft March 18, 2024 08:59
@simonsso simonsso changed the title Initial implementation Sponsorship vector implementation Mar 18, 2024
Copy link

codecov bot commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.84%. Comparing base (304dfc1) to head (7cc3738).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #836      +/-   ##
==========================================
+ Coverage   63.95%   64.84%   +0.88%     
==========================================
  Files          58       58              
  Lines       11589    11880     +291     
==========================================
+ Hits         7412     7703     +291     
  Misses       4177     4177              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@simonsso
Copy link
Contributor Author

Batch mode, I think we only need to support batch-all mode from utility pallet.

  • batch_all: Stops on error and reverts everything (all-or-nothing).
  • force_batch: Does not stop on error and only reverts the failed calls (keep-going).
  • batch: Stops on error and only reverts the first failed call (fail-fast).
    ref

@simonsso simonsso self-assigned this Mar 21, 2024
@simonsso simonsso marked this pull request as ready for review March 21, 2024 03:45
@aliXsed
Copy link
Contributor

aliXsed commented Mar 22, 2024

@simonsso it's a nice clear approach. I like it. I have just added some comments to improve the tests.

@codecov-commenter
Copy link

codecov-commenter commented Mar 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.03%. Comparing base (98dd59e) to head (4917746).
Report is 6 commits behind head on master.

❗ Current head 4917746 differs from pull request most recent head 49dd6d3. Consider uploading reports for the commit 49dd6d3 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #836      +/-   ##
==========================================
+ Coverage   68.20%   69.03%   +0.83%     
==========================================
  Files          58       58              
  Lines        9356     9609     +253     
==========================================
+ Hits         6381     6634     +253     
  Misses       2975     2975              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@simonsso simonsso merged commit a4f6c42 into master Mar 22, 2024
8 checks passed
@simonsso simonsso deleted the iso/20240318T1756-utilspns branch March 22, 2024 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants