-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sponsorship vector implementation #836
Conversation
simonsso
commented
Mar 18, 2024
•
edited
Loading
edited
- tests for positive case where all pass
- test where some jobs pass but on fails and all is rolled back
- benchmark
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #836 +/- ##
==========================================
+ Coverage 63.95% 64.84% +0.88%
==========================================
Files 58 58
Lines 11589 11880 +291
==========================================
+ Hits 7412 7703 +291
Misses 4177 4177 ☔ View full report in Codecov by Sentry. |
Batch mode, I think we only need to support batch-all mode from utility pallet.
|
…in into iso/20240318T1756-utilspns
@simonsso it's a nice clear approach. I like it. I have just added some comments to improve the tests. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #836 +/- ##
==========================================
+ Coverage 68.20% 69.03% +0.83%
==========================================
Files 58 58
Lines 9356 9609 +253
==========================================
+ Hits 6381 6634 +253
Misses 2975 2975 ☔ View full report in Codecov by Sentry. |