Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(NODLMigration): prepare to create GrantsMigration #45

Merged
merged 2 commits into from
Jul 24, 2024

Conversation

aliXsed
Copy link
Collaborator

@aliXsed aliXsed commented Jul 23, 2024

This a refactor not changing any behaviour according to the tests. I needed this to reuse bridge common functions for grants without duplicating or changing them.

@aliXsed aliXsed requested a review from ETeissonniere July 23, 2024 00:33
Copy link
Member

@ETeissonniere ETeissonniere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refactoring looks good, though two points of considerations due to memory layout changes (namely the introduction of the ProposalStatus struct):

  1. CheckBridge.s.sol will no longer work with the current bridge
  2. MigrationNFT contract wouldn't be redeployable with the current bridge

I wonder if it would make sense to try and maintain backward compatibility with the old storage layout as to keep both of these contract/script usable?

@aliXsed
Copy link
Collaborator Author

aliXsed commented Jul 23, 2024

Refactoring looks good, though two points of considerations due to memory layout changes (namely the introduction of the ProposalStatus struct):

  1. CheckBridge.s.sol will no longer work with the current bridge
  2. MigrationNFT contract wouldn't be redeployable with the current bridge

I wonder if it would make sense to try and maintain backward compatibility with the old storage layout as to keep both of these contract/script usable?

@ETeissonniere very good point. I have now changed it to avoid any modifications of the storage layout.

@aliXsed aliXsed merged commit 90497b7 into main Jul 24, 2024
1 check passed
@aliXsed aliXsed deleted the aliX/grants-migration branch July 24, 2024 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants