Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Sentry tracking to formatting #622

Closed
kanej opened this issue Jan 8, 2025 · 0 comments · Fixed by #623
Closed

Add Sentry tracking to formatting #622

kanej opened this issue Jan 8, 2025 · 0 comments · Fixed by #623
Assignees
@kanej
Labels
status:ready This issue is ready to be worked on

Comments

@kanej
Copy link
Member

kanej commented Jan 8, 2025

We are intending to rollout the beta of solidity-plugin-prettier in the coming months. We are not currently tracking formatting in our telemetry (Sentry).

We need to add in a minimal tracking of invocations and time taken. There should be separate Sentry transaction spans for forge vs prettier runs.
@github-actions github-actions bot added the status:ready This issue is ready to be worked on label Jan 8, 2025
@kanej kanej moved this to Todo in hardhat-vscode Jan 8, 2025
@kanej kanej self-assigned this Jan 8, 2025
kanej added a commit that referenced this issue Jan 8, 2025
@kanej
chore: add Sentry transaction monitoring to formatting
005819a 
Formatting has moved to the server side. We have added Sentry
transaction monitoring to the top level `onDocumentFormatting` call.

There are separate subspans on the Sentry transaction for Forge and
Prettier.

Resolves #622.
@kanej kanej mentioned this issue Jan 8, 2025
Merged
@kanej kanej closed this as completed in #623 Jan 8, 2025
@kanej kanej closed this as completed in 21c767f Jan 8, 2025
@github-project-automation github-project-automation bot moved this from Todo to Done in hardhat-vscode Jan 8, 2025
@kanej kanej mentioned this issue Jan 14, 2025
Merged
kanej added a commit that referenced this issue Jan 14, 2025
@kanej
chore: add Sentry transaction monitoring to formatting
e5f97c3 
Formatting has moved to the server side. We have added Sentry
transaction monitoring to the top level `onDocumentFormatting` call.

There are separate subspans on the Sentry transaction for Forge and
Prettier.

Resolves #622.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kanej kanej

Labels
status:ready This issue is ready to be worked on
Projects
hardhat-vscode
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: add Sentry transaction monitoring to formatting NomicFoundation/hardhat-vscode
1 participant
@kanej