Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/update to slang with wasm #624

Draft
wants to merge 8 commits into
base: chore/move-tests-build-to-own-tsconfig
Choose a base branch
from

Conversation

kanej
Copy link
Member

@kanej kanej commented Jan 13, 2025

Update the version of Slang.

@github-actions github-actions bot added the status:ready This issue is ready to be worked on label Jan 13, 2025
Copy link

socket-security bot commented Jan 13, 2025

New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@types/[email protected] 🔁 npm/@types/[email protected] None 0 868 kB types
npm/[email protected] None 0 7.24 kB federicobond
npm/[email protected] 🔁 npm/[email protected] None 0 22.7 MB typescript-bot

🚮 Removed packages: npm/@nomicfoundation/[email protected]

View full report↗︎

@kanej kanej force-pushed the chore/update-to-slang-with-wasm branch from 207ffc4 to 13847f6 Compare January 13, 2025 17:20
Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.52%. Comparing base (ee9b6b6) to head (13847f6).

Additional details and impacted files
@@             Coverage Diff              @@
##           development     #624   +/-   ##
============================================
  Coverage        54.52%   54.52%           
============================================
  Files              226      226           
  Lines             5199     5199           
  Branches           800      800           
============================================
  Hits              2835     2835           
  Misses            2127     2127           
  Partials           237      237           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kanej kanej force-pushed the chore/update-to-slang-with-wasm branch from 0e4694b to 02960b6 Compare January 15, 2025 18:26
@kanej kanej force-pushed the chore/update-to-slang-with-wasm branch from 02960b6 to 123d3c6 Compare January 15, 2025 18:40
@kanej kanej changed the base branch from development to chore/move-tests-build-to-own-tsconfig January 15, 2025 18:41
Comment on lines +3 to +4
"target": "es2022" /* Set the JavaScript language version for emitted JavaScript and include compatible library declarations. */,
"lib": ["es2023"],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these compatible with recent versions of vscode?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is based on:

However, this was only tentative, it should all be reviewed once the all the parts allow a run through of Slang with WASM.

There is a question about whether we should target Node 18 rather than Node 20 so that we are keeping to the Hardhat node version support promise. This wouldn't affect the VSCode library but you can run the language server independently.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that if it works with vscode is enough. We don't need to keep the same support, as vscode updates on a different cadence.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:ready This issue is ready to be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants