-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore/update to slang with wasm #624
base: chore/move-tests-build-to-own-tsconfig
Are you sure you want to change the base?
Chore/update to slang with wasm #624
Conversation
New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@nomicfoundation/[email protected] |
207ffc4
to
13847f6
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## development #624 +/- ##
============================================
Coverage 54.52% 54.52%
============================================
Files 226 226
Lines 5199 5199
Branches 800 800
============================================
Hits 2835 2835
Misses 2127 2127
Partials 237 237 ☔ View full report in Codecov by Sentry. |
0e4694b
to
02960b6
Compare
This was triggered by the typescript update.
We need better module resolution support as we deal with Slang's ESM packages.
02960b6
to
123d3c6
Compare
"target": "es2022" /* Set the JavaScript language version for emitted JavaScript and include compatible library declarations. */, | ||
"lib": ["es2023"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these compatible with recent versions of vscode?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is based on:
- VSCode is on Node 20
- The tsconfig for working with Node 20 suggests the target and lib selection above: https://www.npmjs.com/package/@tsconfig/node20
However, this was only tentative, it should all be reviewed once the all the parts allow a run through of Slang with WASM.
There is a question about whether we should target Node 18 rather than Node 20 so that we are keeping to the Hardhat node version support promise. This wouldn't affect the VSCode library but you can run the language server independently.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that if it works with vscode is enough. We don't need to keep the same support, as vscode updates on a different cadence.
Update the version of Slang.