Negative block number queried when forked network block number is near zero #4131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o bug/1568-negative-block-number-queried-when-forked-network-block-number-is-near-zero
ChristopherDedominici
added
type:bug
🦋 Changeset detectedLatest commit: 092b771 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@ChristopherDedominici can you add a changeset? |
fvictorio
reviewed
Jul 13, 2023
| latestBlock: bigint, | ||
| maxReorg: bigint | ||
| ): bigint { | ||
| // Design choice: if latestBlock - maxReorg gives a negative number than the newest block will be used |
There was a problem hiding this comment.
Let's explain that we do this because the forked network is almost surely a devnet
packages/hardhat-core/test/internal/hardhat-network/provider/fork/ForkBlockchain.ts
Outdated
Show resolved
Hide resolved
fvictorio
approved these changes
Jul 13, 2023
ChristopherDedominici
deleted the
bug/1568-negative-block-number-queried-when-forked-network-block-number-is-near-zero
branch
ChristopherDedominici
removed
no changeset needed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code line:
const lastSafeBlock = latestBlock - maxReorg;could result in a negative value when maxReorg > latestBlock.Fix: add check, when the difference is a negative number then use latestBlock.