Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename VisitorExitResponse::StepIn to VisitorExitResponse::Continue #451

Merged
merged 1 commit into from
May 10, 2023

Conversation

OmarTawfik
Copy link
Contributor

@OmarTawfik OmarTawfik commented May 9, 2023

Since it is not actually stepping into anything, but it is just about to step out of the current node.

@changeset-bot
Copy link

changeset-bot bot commented May 9, 2023

🦋 Changeset detected

Latest commit: a0c9506

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
changelog Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@OmarTawfik OmarTawfik marked this pull request as ready for review May 10, 2023 02:02
@OmarTawfik OmarTawfik requested a review from a team as a code owner May 10, 2023 02:02
@OmarTawfik OmarTawfik enabled auto-merge May 10, 2023 02:02
Copy link
Contributor

@AntonyBlakey AntonyBlakey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@OmarTawfik OmarTawfik added this pull request to the merge queue May 10, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch May 10, 2023
@OmarTawfik OmarTawfik enabled auto-merge May 10, 2023 02:30
@OmarTawfik OmarTawfik added this pull request to the merge queue May 10, 2023
Merged via the queue into NomicFoundation:main with commit 78f633c May 10, 2023
@OmarTawfik OmarTawfik deleted the fix-visitor-api branch May 10, 2023 02:51
@github-actions github-actions bot mentioned this pull request May 10, 2023
OmarTawfik pushed a commit that referenced this pull request May 11, 2023
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and publish to npm
yourself or [setup this action to publish
automatically](https://github.com/changesets/action#with-publishing). If
you're not ready to do a release yet, that's fine, whenever you add more
changesets to main, this PR will be updated.


# Releases
## @nomicfoundation/[email protected]

### Minor Changes

- [#457](#457)
[`b7aae2a`](b7aae2a)
Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - minor grammar
fixes

- [#453](#453)
[`0f2f9ab`](0f2f9ab)
Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - move Rust's
`syntax::Parser::Language` API to root module

- [#454](#454)
[`85dec01`](85dec01)
Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - moving to Rust
version 1.65.0

- [#456](#456)
[`c6d1041`](c6d1041)
Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - expose
`ParseError` API

- [#451](#451)
[`78f633c`](78f633c)
Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - rename
`VisitorExitResponse::StepIn` to `VisitorExitResponse::Continue`

## [email protected]

### Minor Changes

- [#457](#457)
[`b7aae2a`](b7aae2a)
Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - minor grammar
fixes

- [#453](#453)
[`0f2f9ab`](0f2f9ab)
Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - move Rust's
`syntax::Parser::Language` API to root module

- [#454](#454)
[`85dec01`](85dec01)
Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - moving to Rust
version 1.65.0

- [#456](#456)
[`c6d1041`](c6d1041)
Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - expose
`ParseError` API

- [#451](#451)
[`78f633c`](78f633c)
Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - rename
`VisitorExitResponse::StepIn` to `VisitorExitResponse::Continue`

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants