Use both char and byte positions #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: f4eecf9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
OmarTawfik
reviewed
May 11, 2023
OmarTawfik
reviewed
May 11, 2023
OmarTawfik
reviewed
May 11, 2023
OmarTawfik
reviewed
May 11, 2023
crates/codegen/syntax_templates/src/typescript/parser_output.rs
Outdated
Show resolved
Hide resolved
OmarTawfik
reviewed
May 11, 2023
crates/codegen/syntax_templates/src/typescript/parser_output.rs
Outdated
Show resolved
Hide resolved
OmarTawfik
reviewed
May 11, 2023
.../solidity/testing/snapshots/cst_output/Expression/unicode_string_literal/generated/0.7.0.yml
Outdated
Show resolved
Hide resolved
OmarTawfik
requested changes
May 11, 2023
OmarTawfik
reviewed
May 12, 2023
AntonyBlakey
force-pushed
the
AntonyBlakey/use-both-byte-and-char-positions
branch
from
ca821a6 to
f4eecf9
Compare
OmarTawfik
approved these changes
May 12, 2023
Merged
OmarTawfik
added a commit
to OmarTawfik-forks/slang
that referenced
this pull request
May 12, 2023
Follow up on NomicFoundation#458 Turns out that using `#[napi(ts_return_type = "number")]` only affects the return type in the generated `index.d.ts` file, but not the actual return type at runtime. Now we are using `usize`, which maps to JavaScript's `BigInt` by default, which is not ideal to work with at all. Using `u32` instead which maps to JavaScript's `number` type. Also, adds a few missing `getter` attributes, and adds a test to check the new types.
OmarTawfik
added a commit
to OmarTawfik-forks/slang
that referenced
this pull request
May 12, 2023
Follow up on NomicFoundation#458 Turns out that using `#[napi(ts_return_type = "number")]` only affects the return type in the generated `index.d.ts` file, but not the actual return type at runtime. Now we are using `usize`, which maps to JavaScript's `BigInt` by default, which is not ideal to work with at all. Using `u32` instead which maps to JavaScript's `number` type. Also, adds a few missing `getter` attributes, and adds a test to check the new types.
OmarTawfik
added a commit
to OmarTawfik-forks/slang
that referenced
this pull request
May 12, 2023
Follow up on NomicFoundation#458 - make sure test snapshots padding uses chars instead of bytes - fixed a minor bug with rendering error messages on empty source input, as it expects line/col, not start/end bytes.
OmarTawfik
added a commit
to OmarTawfik-forks/slang
that referenced
this pull request
May 12, 2023
Follow up on NomicFoundation#458 - make sure test snapshots padding uses chars instead of bytes - fixed a minor bug with rendering error messages on empty source input, as it expects line/col, not start/end bytes.
OmarTawfik
added a commit
that referenced
this pull request
May 16, 2023
Turns out that using `#[napi(ts_return_type = "number")]` only affects the return type in the generated `index.d.ts` file, but not the actual return type at runtime. Currently we are using `usize`, which maps to JavaScript's `BigInt` by default, which means our types are incorrect. This PR uses `u32` instead which maps to JavaScript's `number` type. Also adds a few missing `getter` attributes, and adds a test to check the new types. Follow up on #458
OmarTawfik
added a commit
to OmarTawfik-forks/slang
that referenced
this pull request
May 16, 2023
Follow up on NomicFoundation#458 - make sure test snapshots padding uses chars instead of bytes - fixed a minor bug with rendering error messages on empty source input, as it expects line/col, not start/end bytes.
OmarTawfik
pushed a commit
that referenced
this pull request
May 16, 2023
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and publish to npm yourself or [setup this action to publish automatically](https://github.com/changesets/action#with-publishing). If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @nomicfoundation/[email protected] ### Minor Changes - [#458](#458) [`c0fc7e9`](c0fc7e9) Thanks [@AntonyBlakey](https://github.com/AntonyBlakey)! - Record both character and byte offsets for input positions - [#463](#463) [`0958d6b`](0958d6b) Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - use `number` and getters in npm public API ## [email protected] ### Minor Changes - [#458](#458) [`c0fc7e9`](c0fc7e9) Thanks [@AntonyBlakey](https://github.com/AntonyBlakey)! - Record both character and byte offsets for input positions - [#463](#463) [`0958d6b`](0958d6b) Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - use `number` and getters in npm public API Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
OmarTawfik
added a commit
that referenced
this pull request
May 17, 2023
Follow up on #458 - make sure test snapshots padding uses chars instead of bytes - fixed a minor bug with rendering error messages on empty source input, as it expects line/col, not start/end bytes.
OmarTawfik
added a commit
that referenced
this pull request
May 24, 2023
Follow up on #458 - make sure test snapshots padding uses chars instead of bytes - fixed a minor bug with rendering error messages on empty source input, as it expects line/col, not start/end bytes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.