refactor parser codegen #497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
AntonyBlakey
approved these changes
Jun 15, 2023
- move parsing tokens to a common function - remove the need to pass token names as static strings everywhere, since we already have `strum` AsRefStr` deriver This decreases nesting, improves readability of the parser code, and decreases the generated code by roughly 30%.
OmarTawfik
force-pushed
the
refactor-parser-codegen
branch
from
67ed043 to
7e9ed20
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
strum::AsRefStrderiverThis decreases nesting, improves readability of the parser code, and decreases the generated code by roughly 30%.
But most importantly, it unblocks #498 and #500 by making it easier to generate named or unnamed nodes at each parser root.