Drive-by tweaks and docs #561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These seem to be redundant: any crate using the `solidity_language::SolidityLanguageExtensions` will by rebuilt if the `solidity_language` crate changes but it was that package's build script that defined the variable that was explicitly depended upon by the callers, so no need to manually instruct Cargo here.
See https://generated.at/. This is already used by Cargo.lock and Rustfmt supports it: rust-lang/rustfmt#3958
...however Clippy does not honor the @generated and needs an explicit allow setting, see rust-lang/rust-clippy#702.
🦋 Changeset detectedLatest commit: 64b4152 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
OmarTawfik
reviewed
Aug 3, 2023
OmarTawfik
reviewed
Aug 3, 2023
OmarTawfik
reviewed
Aug 3, 2023
OmarTawfik
requested changes
Aug 3, 2023
|
This now has only the docs and the removed extraneous Cargo markers. Let me know if this makes sense 👍 |
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 27, 2023
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and publish to npm yourself or [setup this action to publish automatically](https://github.com/changesets/action#with-publishing). If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @nomicfoundation/[email protected] ### Minor Changes - [#595](#595) [`1a258c4`](1a258c4) Thanks [@Xanewok](https://github.com/Xanewok)! - Attempt error recovery when parsing incomplete lists - [#564](#564) [`e326a06`](e326a06) Thanks [@AntonyBlakey](https://github.com/AntonyBlakey)! - Parsing operators with missing operands should no longer panic - [#564](#564) [`e326a06`](e326a06) Thanks [@AntonyBlakey](https://github.com/AntonyBlakey)! - Inline parse rules are no longer exposed to the API. - [#564](#564) [`e326a06`](e326a06) Thanks [@AntonyBlakey](https://github.com/AntonyBlakey)! - Scanners are no longer available as methods - use next_token instead - [#564](#564) [`e326a06`](e326a06) Thanks [@AntonyBlakey](https://github.com/AntonyBlakey)! - Scanners are now grouped into contexts to deal with contextual scanning ### Patch Changes - [#601](#601) [`cbd2a79`](cbd2a79) Thanks [@Xanewok](https://github.com/Xanewok)! - Attempt parser error recovery between bracket delimiters - [#599](#599) [`4bbad48`](4bbad48) Thanks [@Xanewok](https://github.com/Xanewok)! - Use correct versions for the `revert` and `global` keywords - [#561](#561) [`cb6a138`](cb6a138) Thanks [@Xanewok](https://github.com/Xanewok)! - Add preliminary documentation for the `solidity_language` Rust package Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not touching the grammar definition-related code since that's about to be changed by https://github.com/AntonyBlakey/slang/tree/AntonyBlakey/to_rust_types.
Somewhat related to #234, I noticed that we have public extension traits that seem to only work with the
LanguageDefinitiontype. Maybe we should change these one-function traits to free functions that accept the language definition as the argument, instead?Also not feeling strongly about 84912e8, thought it's more of a nice-to-have.