Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Add an introduction and a design overview to the user guide #674

Merged
merged 10 commits into from
Dec 3, 2023

Conversation

Xanewok
Copy link
Contributor

@Xanewok Xanewok commented Nov 24, 2023

In preparation for #334 (and other how-tos).

This adds a bit more introduction and context to the user guide that should be independent on the actual API used (Rust/TS) and also provides stubs for the How-Tos on the parsing/navigating the syntax tree.

When I tried to write these specific how-tos, I thought that we should be able to define, at least from the higher level, what the CST is, how the process looks like and add some more context (e.g. multiple versions and why we need to create a specific version for the language, first). Also this helps establish a bit more structure to the guide that should help with writing more documentation/guides as we go.

Ironically, http://shader-slang.com/slang/user-guide/index.html helped me structure this a bit as a guide that the user is welcomed to and what they might benefit from (intro, context) before diving deeper into the guides/context.

And provide stubs for the How-Tos on parsing/navigating the syntax tree.
@Xanewok Xanewok requested a review from a team as a code owner November 24, 2023 18:50
Copy link

changeset-bot bot commented Nov 24, 2023

⚠️ No Changeset found

Latest commit: e0aa06f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

README.md Show resolved Hide resolved
documentation/public/user-guide/overview.md Outdated Show resolved Hide resolved
documentation/public/user-guide/introduction.md Outdated Show resolved Hide resolved
documentation/public/user-guide/introduction.md Outdated Show resolved Hide resolved
@Xanewok
Copy link
Contributor Author

Xanewok commented Nov 27, 2023

Updated!

Copy link
Contributor

@OmarTawfik OmarTawfik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few questions/suggestions.

Copy link
Contributor

@OmarTawfik OmarTawfik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one suggestion.

@Xanewok Xanewok enabled auto-merge December 1, 2023 10:03
@Xanewok
Copy link
Contributor Author

Xanewok commented Dec 1, 2023

@AntonyBlakey I believe this is still blocked on your re-review

@Xanewok
Copy link
Contributor Author

Xanewok commented Dec 2, 2023

Just noticed #534; this PR introduces CST but the new concepts.md is a good place to introduce remaining concepts listed in #534

@Xanewok Xanewok added this pull request to the merge queue Dec 3, 2023
Merged via the queue into NomicFoundation:main with commit 0d38622 Dec 3, 2023
1 check passed
@Xanewok Xanewok deleted the cursor-howto branch December 3, 2023 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants